[BUG] Sorting on a field of type basic_date_time_no_millis gives a java.time.DateTimeException #11138
Comments
|
fyi |
|
also, if we set size=3 Note: if we sort by integer field and a doc have no value, we got -Int.MAX_VALUE. Assuming that handling absent integers is correct, how to handle formatting -Long.MAX_VALUE into date? Should we cap years to -9999? |
when sorting by date column, missing values transferred as Long.MIN/MAX_VAL see IndexFieldData.XFieldComparatorSource.missingObject() When this value formatted for merging in coordinator it hit the error.
|
Sharing some observations: I need a suggestion to continue work on this. see https://opensearch.org/docs/latest/field-types/supported-field-types/date/#built-in-formats |
|
This interesting, we have a change merged recently #11196 related to |
|
@reta, I suppose #11196 test would fail if we add dates with some basic_* format there. |
|
@gashutos Could you take a stab and share your thoughts on this? |
This should get fixed with above PR. @mkhludnev if you get chance to test this on latest version. |
You already tested, cool let me see what more is required there. |
|
@gashutos closing this out as based on search community meeting discussion. Feel free to re-open if you find anything more on this |
Describe the bug
Background:
Problem: when sorted by this field with
size = <number of search results>, OpenSearch returns a Java exception. Full queries are laid out in section "To Reproduce".{ "error": { "root_cause": [ { "type": "response_handler_failure_transport_exception", "reason": "java.time.DateTimeException: Field Year cannot be printed as the value -292275055 exceeds the maximum print width of 4" } ], "type": "search_phase_execution_exception", "reason": "all shards failed", "phase": "query", "grouped": true, "failed_shards": [ { "shard": 0, "index": "test_es_issue_81960", "node": "MqBH-lbkRyyOCTK7hWJmow", "reason": { "type": "response_handler_failure_transport_exception", "reason": "java.time.DateTimeException: Field Year cannot be printed as the value -292275055 exceeds the maximum print width of 4", "caused_by": { "type": "date_time_exception", "reason": "Field Year cannot be printed as the value -292275055 exceeds the maximum print width of 4" } } } ] }, "status": 500 }To Reproduce
Create an index without a date field.
PUT {{host}}/{{index}}{ "mappings": { "dynamic": "strict", "properties": { "username": { "type": "keyword" }, "last_seen": { "format": "basic_date_time_no_millis", "type": "date" } } } }Index some documents. One with the date value, another without.
POST {{host}}/_bulk{ "index": { "_index": "test_es_issue_81960", "_id": "1" } } { "username" : "ann" } { "index": { "_index": "test_es_issue_81960", "_id": "2" } } { "username" : "bob", "last_seen" : "20231015T144500Z" }Search query "Q1":
{ "query": { "match_all": {} }, "size": 2, "sort": [ { "last_seen": { "order": "desc" } } ] }The query fails with
sizeset to2(the number of documents in the index). Values1and3forsizework. Addingmissing=0seems to be a workaround.Expected behavior
Query "Q1" (above) should return result:
{ "took": 1, "timed_out": false, "_shards": { "total": 1, "successful": 1, "skipped": 0, "failed": 0 }, "hits": { "total": { "value": 2, "relation": "eq" }, "max_score": null, "hits": [ { "_index": "test_es_issue_81960", "_id": "2", "_score": null, "_source": { "username": "bob", "last_seen": "20231015T144500Z" }, "sort": [ 1697381100000 ] }, { "_index": "test_es_issue_81960", "_id": "1", "_score": null, "_source": { "username": "ann" }, "sort": [ 0 ] } ] } }Plugins
None.
Screenshots
Host/Environment (please complete the following information):
Additional context
Tried and reproduced on OpenSearch 2.5.0 and 2.11.0.
This has been reported for ElasticSearch also: elastic/elasticsearch#81960
The text was updated successfully, but these errors were encountered: