Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Automatically merge dependabot changes and other maintenance work #10211

Open
peternied opened this issue Sep 25, 2023 · 2 comments
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request

Comments

@peternied
Copy link
Member

Is your feature request related to a problem? Please describe.
There are an increasing number of automated tools and small changes that don't need as much attention from maintainers, such as version bumps where CI is sufficient to ensure the quality of the build. These pull requests are often distracting and easy to ignore and they tend to pile up, it would be great if changes of this type could be automated.

Describe the solution you'd like
It would be great if there was a tool that checked after all CI checks had passed and would then automatically merge changes.

Describe alternatives you've considered
Keep depending on manual reviews by maintainers to merge changes.

@peternied peternied added enhancement Enhancement or improvement to existing feature or request untriaged labels Sep 25, 2023
@peternied
Copy link
Member Author

Proposal

I've made a PR [1] + tool [2] for doing this in OpenSearch-build for changes to manifest files. After specifying a list of approved authors against a list of file globs this could be instituted in OpenSearch for dependabot change on build.gradle files.

reta pushed a commit to opensearch-project/security that referenced this issue Sep 26, 2023
…3408)

### Description
Allow for automatic merging of dependabot changes after checks pass

### Issues Resolved
- Related opensearch-project/OpenSearch#10211

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <[email protected]>
opensearch-trigger-bot bot pushed a commit to opensearch-project/security that referenced this issue Sep 26, 2023
…3408)

### Description
Allow for automatic merging of dependabot changes after checks pass

### Issues Resolved
- Related opensearch-project/OpenSearch#10211

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit ab891d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied peternied changed the title [Automation] Automatically dependabot changes and other maintenance work [Automation] Automatically merge dependabot changes and other maintenance work Oct 18, 2023
@peternied
Copy link
Member Author

With the status of the CI system this doesn't like much of a value to prioritize, of 10/18 CI only seems to be passing 25% of the time.

@ankitkala ankitkala added discuss Issues intended to help drive brainstorming and decision making and removed Other labels Dec 17, 2023
@ticheng-aws ticheng-aws added Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. and removed Build Libraries & Interfaces Other labels Jan 4, 2024
@rishabh6788 rishabh6788 removed untriaged Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

5 participants