From e02c8b3621a9e51642b0727a2a58d35c65608353 Mon Sep 17 00:00:00 2001 From: Gaurav Bafna Date: Sun, 22 Oct 2023 17:40:57 +0530 Subject: [PATCH] more PR comments Signed-off-by: Gaurav Bafna --- .../org/opensearch/index/translog/RemoteFsTranslogTests.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/src/test/java/org/opensearch/index/translog/RemoteFsTranslogTests.java b/server/src/test/java/org/opensearch/index/translog/RemoteFsTranslogTests.java index f513f3be52e84..3cb65610fab58 100644 --- a/server/src/test/java/org/opensearch/index/translog/RemoteFsTranslogTests.java +++ b/server/src/test/java/org/opensearch/index/translog/RemoteFsTranslogTests.java @@ -169,10 +169,6 @@ private RemoteFsTranslog create(Path path) throws IOException { return create(path, createRepository(), translogUUID, 0); } - private RemoteFsTranslog create(Path path, int extraGenToKeep) throws IOException { - return create(path, extraGenToKeep); - } - private RemoteFsTranslog create(Path path, BlobStoreRepository repository, String translogUUID, int extraGenToKeep) throws IOException { this.repository = repository; globalCheckpoint = new AtomicLong(SequenceNumbers.NO_OPS_PERFORMED); @@ -739,6 +735,7 @@ public void testSimpleOperationsUpload() throws Exception { // this should now trim as tlog-2 files from remote, but not tlog-3 and tlog-4 addToTranslogAndListAndUpload(translog, ops, new Translog.Index("2", 2, primaryTerm.get(), new byte[] { 1 })); assertEquals(2, translog.stats().estimatedNumberOfOperations()); + assertBusy(() -> assertTrue(translog.isRemoteGenerationDeletionPermitsAvailable())); translog.setMinSeqNoToKeep(2); // this should now trim as tlog-2 files from remote, but not tlog-3 and tlog-4