Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Revisit updated header spacing #7759

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0a3bcd8 from #7741.

Also:
* Bump OUI to 1.10.0

Signed-off-by: Miki <[email protected]>
(cherry picked from commit 0a3bcd8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (95c9f3a) to head (7980703).
Report is 3 commits behind head on 2.x.

Files Patch % Lines
...ation/public/top_nav_menu/top_nav_control_item.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7759   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files        3652     3652           
  Lines       80970    80972    +2     
  Branches    12875    12876    +1     
=======================================
+ Hits        51724    51726    +2     
  Misses      26085    26085           
  Partials     3161     3161           
Flag Coverage Δ
Linux_1 30.12% <0.00%> (-0.01%) ⬇️
Linux_2 55.98% <100.00%> (+<0.01%) ⬆️
Linux_3 40.54% <0.00%> (-0.01%) ⬇️
Linux_4 31.48% <20.00%> (+<0.01%) ⬆️
Windows_1 30.14% <0.00%> (-0.01%) ⬇️
Windows_2 55.93% <100.00%> (+<0.01%) ⬆️
Windows_3 40.54% <0.00%> (-0.01%) ⬇️
Windows_4 31.48% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 1987d5c into 2.x Aug 20, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants