[BUG] User Theme Selection doesn't retain theme selection

[virajsanghvi]

Describe the bug

After selecting a theme from the user themes selector in the header, the theme gets applied, but the popover doesn't retain the setting. This is because browser based settings don't override persisted settings when the component gets the current value of the setting.

To Reproduce
Steps to reproduce the behavior:

1. Open theme selector in header
2. Select a theme that isn't next/v8.
3. theme will be applied, but if you reopen theme selector, next/v8 will be selected

Expected behavior
The theme selector shows the currently selected theme.

OpenSearch Version
N/A

Dashboards Version
OSD/main (unreleased feature)

Plugins

N/A

Screenshots

N/A

Host/Environment (please complete the following information):
all

Additional context

N/A

[joshuali925]

i'm not able to reproduce this on current main

[virajsanghvi]

Turn off user based preferences, set another theme in advanced settings as an admin, and then turn on user based preferences - i think you should be able to repro.

[virajsanghvi]

I think the issue is that it treats browser based settings as a default (

OpenSearch-Dashboards/src/core/public/ui_settings/ui_settings_client.ts

Line 65 in 9a84202

this.cache = defaultsDeep(this.cache, this.getBrowserStoredSettings());

), so if the admin has already selected a value, the admin configured value is returned when calling uiSettingsClient.get()

[joshuali925]

thanks for the details, i'm able to reproduce now