Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the Data Source picker accept blank labels? #7674

Open
AMoo-Miki opened this issue Aug 9, 2024 · 0 comments
Open

Should the Data Source picker accept blank labels? #7674

AMoo-Miki opened this issue Aug 9, 2024 · 0 comments
Assignees

Comments

@AMoo-Miki
Copy link
Collaborator

Describe the bug
I noticed that a test allows for the data source selection trigger, DataSourceMenuPopoverButton, to have no label and render as such. Is this is a permitted possibility?

https://github.com/opensearch-project/OpenSearch-Dashboards/tree/b9ac31e323be11d8b995945622faf371c4ff9893/src/plugins/data_source_management/public/components/popover_button/popover_button.test.tsx#L31

If it is permitted, we should use OuiButtonIcon, but if not, we should disallow it.

CC: @kgcreative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants