Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Restrict unassigned data source access for non dashboard admin #7181

Closed
wanglam opened this issue Jul 5, 2024 · 0 comments
Closed
Labels
enhancement New feature or request

Comments

@wanglam
Copy link
Contributor

wanglam commented Jul 5, 2024

Is your feature request related to a problem? Please describe.

This is a feature request. Only dashboard admin can access unassigned data source saved objects after workspaces and savedObjects.permission enabled. For non dashboard admin users, they only can access assigned data sources in workspaces. For now, non dashboard admin can access unassigned data sources through the API directly.

Describe the solution you'd like

Modify the workspace permission saved object client wrapper, add specific logic to check if saved objects are unassigned data sources in the permission validation method. The permission validation method will be used in the RUD methods. For unassigned data sources, these methods will receive a navigate validation result and then will throw permission error.

Describe alternatives you've considered

N/A

Additional context

#4944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant