Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Use release min artifact if available #1201

Open
kavilla opened this issue Feb 2, 2022 · 2 comments
Open

[Tests] Use release min artifact if available #1201

kavilla opened this issue Feb 2, 2022 · 2 comments

Comments

@kavilla
Copy link
Member

kavilla commented Feb 2, 2022

Is your feature request related to a problem? Please describe.

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/packages/osd-opensearch/src/artifact.js#L189
Only accepts from -SNAPSHOT builds, but when a release is a cut for OpenSearch we can use the release min if it's available.

Describe the solution you'd like

On the branch 1.2 I can run the integration tests yarn test:jest_integration and it will use the artifact from https://artifacts.opensearch.org/releases/core/opensearch/1.2.0/opensearch-min-1.2.0-linux-x64.tar.gz instead of attempting to use the https://artifacts.opensearch.org/snapshots/core/opensearch/1.2.0-SNAPSHOT/opensearch-min-1.2.0-SNAPSHOT-linux-x64-latest.tar.gz

Describe alternatives you've considered

n/a

Additional context

Will need to verify the non-snapshot works fine.

@dblock
Copy link
Member

dblock commented Feb 2, 2022

The code should first attempt to get a released version of OpenSearch, then fallback to a -SNAPSHOT version if that's not available.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 9, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
# [31.0.0](elastic/elastic-charts@v30.2.0...v31.0.0) (2021-06-29)

### Bug Fixes

* **xy:** render gridlines behind axis  ([opensearch-project#1204](elastic/elastic-charts#1204)) ([bf9ccbd](elastic/elastic-charts@bf9ccbd)), closes [#1203](elastic/elastic-charts#1203)
* memory leak related to re-reselect cache ([opensearch-project#1201](elastic/elastic-charts#1201)) ([8cb6876](elastic/elastic-charts@8cb6876))
* **partition:** getLegendItemsExtra no longer assumes a singleton ([opensearch-project#1199](elastic/elastic-charts#1199)) ([ecbcc1e](elastic/elastic-charts@ecbcc1e))

### Features

* **annotations:** option to render rect annotations outside chart ([opensearch-project#1207](elastic/elastic-charts#1207)) ([ddffc00](elastic/elastic-charts@ddffc00))
* **heatmap:** enable brushing on categorical charts ([opensearch-project#1212](elastic/elastic-charts#1212)) ([5c426b3](elastic/elastic-charts@5c426b3)), closes [opensearch-project#1170](elastic/elastic-charts#1170) [opensearch-project#1171](elastic/elastic-charts#1171)
* **xy:** add onPointerUpdate debounce and trigger options ([opensearch-project#1194](elastic/elastic-charts#1194)) ([aa068f6](elastic/elastic-charts@aa068f6))

### BREAKING CHANGES

* **xy:** the `PointerOverEvent` type now extends `ProjectedValues` and drops value. This effectively replaces value with `x`, `y`, `smVerticalValue` and `smHorizontalValue`.
@joshuarrrr
Copy link
Member

@kavilla Can you provide a little bit of additional context about the difference between the min and the snapshot builds, and under which circumstances we'd prefer one over the other? Should we fall back to the snapshot artifact if the min build is unavailable? Do we need to allow users to specify their preference via a CLI arg?

Will any of the logic need to change to accomodate a switch from ci.opensearch.org to artifacts.opensearch.org as suggested in opensearch-project/opensearch-build#2114?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants