You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ammachado in the configuration properties recipes, we say that the elements can be regexp but in fact they always are, right?
So if you want to replace quarkus.something key, you actually need to define quarkus\.something or you will also replace quarkuswsomethingor quarkus-something.
Did you have time to think about it? I can implement it, I just wanted to make sure you were in line with the idea and I didn't want to step on your toes.
I used regex on the property recipes due to the changes required on properties that have map keys. If there's a flag to enable regexes for the property keys, how the recipe will capture the parts of the config that are independent of the map key? I can make changes to accommodate substitutions in separate parts, but to me it seems that the regex is a simpler approach.
@ammachado in the configuration properties recipes, we say that the elements can be regexp but in fact they always are, right?
So if you want to replace
quarkus.something
key, you actually need to definequarkus\.something
or you will also replacequarkuswsomething
orquarkus-something
.This makes things a bit more complex than they need to be and also not in line with https://docs.openrewrite.org/recipes/properties/changepropertykey where you have this
regex
boolean to actually enable regexp transformation.I wonder if we should change the current behavior to avoid regexps in the default case and only enable regexps when
regex
is set to true.That would be a breaking change but I think these recipes are new enough that it's worth breaking them to be consistent with the rest of OpenRewrite.
I thought about that because I was migrating old Quarkus Update recipes to this new stuff.
WDYT?
/cc @timtebeek for advice.
The text was updated successfully, but these errors were encountered: