Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace
ArrayStoreException
withTypeNotPresentException
in try/catch usingClass.getAnnotation()
#613Replace
ArrayStoreException
withTypeNotPresentException
in try/catch usingClass.getAnnotation()
#613Changes from 7 commits
ffc2e15
81f9345
e31a547
8471357
d2a31af
ff55ffa
ce5a572
7a27436
9cfb45c
e3574fc
657ebd5
18595ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a Precondition here to only call the visitor when
classGetAnnotationMethod
is used. That way we can reject the vast majority of classes without visiting any elements, for a nice performance boost.