New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace `ArrayStoreException` with `TypeNotPresentException` in try/catch using `Class.getAnnotation()` #613

Merged

timtebeek merged 12 commits into openrewrite:main from BhavanaPidapa:Recipe_ClassGetAnnotationMethod

Nov 25, 2024

Contributor

BhavanaPidapa commented Nov 22, 2024

What's changed?

This PR contains recipe - org.openrewrite.java.migrate.ArrayStoreExceptionToTypeNotPresentException
Rule:

What's your motivation?

This custom recipe replaces catch blocks for ArrayStoreException around getAnnotation() with TypeNotPresentException to ensure compatibility with Java 11+.

Anyone you would like to review specifically?

@timtebeek @cjobinabo

Checklist

I've added unit tests to cover both positive and negative cases
I've read and applied the recipe conventions and best practices
I've used the IntelliJ IDEA auto-formatter on affected files

bhavanapidapa added 5 commits

November 19, 2024 14:09


          draft recipe and test case

ffc2e15


          Added the recipe to the list

81f9345


          Merge Conflicts

e31a547


          Custom Recipe and test cases for changing exception type


          Updated the display name

d2a31af

BhavanaPidapa changed the title ~~Recipe class get annotation method~~ Recipe Replace ArrayStoreException with TypeNotPresentException

github-actions bot reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Show resolved Hide resolved

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

src/test/java/org/openrewrite/java/migrate/TypeNotPresentExceptionTest.java Outdated Show resolved Hide resolved


          Added the copyright to the files

ff55ffa

github-actions bot reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

src/test/java/org/openrewrite/java/migrate/TypeNotPresentExceptionTest.java Outdated Show resolved Hide resolved

timtebeek self-requested a review

November 24, 2024 20:59

timtebeek assigned BhavanaPidapa

timtebeek reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

timtebeek reviewed

View reviewed changes

src/test/java/org/openrewrite/java/migrate/TypeNotPresentExceptionTest.java Outdated Show resolved Hide resolved


          Apply suggestions from code review

ce5a572

timtebeek added the recipe label

timtebeek reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

timtebeek reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

src/test/java/org/openrewrite/java/migrate/TypeNotPresentExceptionTest.java Outdated Show resolved Hide resolved

src/test/java/org/openrewrite/java/migrate/TypeNotPresentExceptionTest.java Outdated Show resolved Hide resolved

timtebeek reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated

+                  @Override
+                  public TreeVisitor<?, ExecutionContext> getVisitor() {
+                      final MethodMatcher classGetAnnotationMethod = new MethodMatcher("java.lang.Class getAnnotation(java.lang.Class)");
+                      return new JavaVisitor<ExecutionContext>() {

Contributor

timtebeek Nov 24, 2024

Let's add a Precondition here to only call the visitor when classGetAnnotationMethod is used. That way we can reject the vast majority of classes without visiting any elements, for a nice performance boost.

timtebeek reviewed

View reviewed changes

src/main/java/org/openrewrite/java/migrate/ArrayStoreExceptionToTypeNotPresentException.java Outdated Show resolved Hide resolved

timtebeek and others added 3 commits

November 24, 2024 22:56


          Apply suggestions from code review

7a27436

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Remove unnecessary trailing newline

9cfb45c


          Apply suggestions from code review

e3574fc

timtebeek changed the title ~~Recipe Replace ArrayStoreException with TypeNotPresentException~~ Replace ArrayStoreException with TypeNotPresentException in try/catch using getAnnotation()

bhavanapidapa and others added 2 commits

November 25, 2024 13:37


          Fixed the code as mentioned in comments

657ebd5


          Use a Precondition, ListUtils, and prevent unnecessary changes

18595ca

timtebeek approved these changes

View reviewed changes

Contributor

timtebeek left a comment

Thanks for kicking this off @BhavanaPidapa ; I've applied a few small changes in 18595ca to simplify the implementation and use established patterns. Approved from my side & ready to merge.

timtebeek changed the title ~~Replace ArrayStoreException with TypeNotPresentException in try/catch using getAnnotation()~~ Replace ArrayStoreException with TypeNotPresentException in try/catch using Class.getAnnotation()

timtebeek merged commit c48a656 into openrewrite:main

2 checks passed

BhavanaPidapa mentioned this pull request

Recipe IllegalArgumentExceptionToAlreadyConnectedException #615

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe