Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in DependencyInsight recipe #71

Open
mike-solomon opened this issue Feb 7, 2024 · 1 comment
Open

Fix issues in DependencyInsight recipe #71

mike-solomon opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mike-solomon
Copy link
Contributor

Right now, the data table produced by the DependencyInsight recipe results in a massive amount of irrelevant/duplicate data:

Screen Shot 2024-02-06 at 9 59 38 AM

There are two primary issues:

  1. When multiple different dependencies bring in the same thing (e.g., jackson-core), a new entry is added - but we are not recording the name of the dependency which actually brings it into the data table. This makes it difficult to see what's actually going on and diminishes the use of the table.
  2. On top of the above issue, the recipe searches through dependencies transitively - so you can end up where you have only one or two dependencies in the project but those dependencies depend on something else that depends on something else and then you end up with 50 rows all depending on the same thing as you trace through all of the projects. We should consider some type of de-duplication here to make this table more relevant.
@mike-solomon mike-solomon added the bug Something isn't working label Feb 7, 2024
@mike-solomon mike-solomon changed the title Fix dupe issues in DependencyInsight recipe Fix issues in DependencyInsight recipe Feb 7, 2024
@okundzich
Copy link
Member

@sambsnyd I think you were making changes to this area

@timtebeek timtebeek moved this to Backlog in OpenRewrite Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants