@TypeDef not working properly

[A1016375]

Original Code:

@TypeDef(name = "jsonb", typeClass = JsonBinaryType.class)

@Type(type = "json")
	@Column(name = "branding_json", columnDefinition = "json")
	private JSONObject branding_json;

---

After openrewrite Upgrade

@TypeDef(name = "jsonb", typeClass = JsonBinaryType.class)

**@Type(jsonb.class)** <-- Giving Error
	@Column(name = "branding_json", columnDefinition = "json")
	private JSONObject branding_json;

---

Excepted Changes

@TypeDef(name = "jsonb", typeClass = JsonBinaryType.class) **<-- This line should be removed**

**@Type(JsonBinaryType.class)** **<-- This line should be** 
	@Column(name = "branding_json", columnDefinition = "json")
	private JSONObject branding_json;

[timtebeek]

Thanks for the report @A1016375 ! Indeed not covered yet, although at first glance it seems doable. Is this something you'd want to help add to the recipe module?

[abccbaandy]

Not sure if same issue.

uuid migrate is wrong too.

before

    @Type(type = "uuid-char")

after

    @Type(uuid-char.class)

uuid-char.class is not even exist

According to this link, should be

    @JdbcTypeCode(java.sql.Types.VARCHAR)

[timtebeek]

Thanks for chiming in @abccbaandy ; this would be another special case to handle, similar as how we've covered temporal types:

• Convert temporal types in the switch to Hibernate 6 #41

Welcome to push up a draft with a failing test and then we'll work out the next steps from there.

[BrayanMnz]

What are the plans on this? @timtebeek

Should someone add a recipe to update @typedef to @convert with the right attribute names?

I would love to take a look at it and help with the fix

[timtebeek]

hi @BrayanMnz ; great seeing you here! Yes help would be much appreciated; if you push up a draft PR with only additional tests I can assign the issue to you and work from there. The example linked above should help as a hint for the implementation, but just a draft PR with tests helps to give early feedback.