-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rewrite-gradle-plugin
to rewrite-recipe-bom
#123
Comments
I would think that |
We declare all our dependencies and versions in a kotlin file we then reference everywhere else. We can specify the gradle plugin version independently, but because the versions of rewrite and the plugin don't match, it becomes extra work to look everything up and ensure everything is compatible. Using a single BOM makes it easy for us to ensure compatibilty. |
That definitely makes sense. As of right now, I think that rewrite has cut it down to 2 versions (from a lot): the
For this to work as described, you'd have to use the platform bom in two places. The first would be for the plugin classpath itself via As a counter example, the below is possible today with the latest versions -- using just the two dependency versions as described previously -- and would be:
|
Yep we already use buildscript dependencies, but without the jar being published to central I think it was an issue. I don't mind repeating the reference in code if I have peace of mind that everything aligns properly. It's also not the end of the world to keep the plugin separate, mostly just a hassle to have to track down both. |
Before doing this, also publish
rewrite-gradle-plugin
to maven central so that corp environment procurement processes don't need to request against Gradle plugin portal.The text was updated successfully, but these errors were encountered: