-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: a bit of polishing #224
Conversation
|
||
// TODO: Return if the varDec is an instance or class variable | ||
|
||
// TODO: If none of the above apply, find all use cases for the variables and determine whether or not they're reassigned. If none have been, add the final modifier. If one ore more has, do nothing. | ||
// TODO: If none of the above apply, find all use cases for the variables and determine whether or not they're reassigned. If none have been, add the final modifier. If one or more has, do nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting typo. Sadly ore
is a word, but ^ore$
could be added to https://github.com/openrewrite/rewrite-docs/blob/master/.github/actions/spelling/reject.txt if it's unlikely to be appropriate in this repository :)
@SimonVerhoeven: sorry, I didn't mean that. You were correct that In fact it's reliably a typo in any construct of the form https://grep.app/search?current=10&q=%28.%5B%5Ee%5D%7C%5B%5En%5De%29%20ore%20more®exp=true&case=true Your caught typo was so good that I've added a rule for it: What I was trying to say is that if this project will never use |
Ahah, sorry. I've updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Thanks so much for making these changes and helping others by improving the docs!
What's changed?
Reworded things a little bit
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
./gradlew licenseFormat