Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riskmetric badge is not rendered correctly #337

Open
timtreis opened this issue Feb 28, 2022 · 4 comments · Fixed by #338
Open

Riskmetric badge is not rendered correctly #337

timtreis opened this issue Feb 28, 2022 · 4 comments · Fixed by #338
Assignees
@timtreis
Labels
blocked Issue that can't progress further at this moment bug Something isn't working issue Used for project filtering

Comments

@timtreis
Copy link
Collaborator

image
@timtreis timtreis added bug Something isn't working issue Used for project filtering labels Feb 28, 2022
@timtreis timtreis linked a pull request Feb 28, 2022 that will close this issue
WIP for GH action -> Fixes riskmetric badge #338
Merged
@timtreis
Copy link
Collaborator Author

timtreis commented Feb 28, 2022 •
edited
Loading

The badge looks weird because shilds.io expects an URL of the format <string>-<number>-<colour>. However, because our riskmetric score is now negative, that format is broken (riskmetric--1.53-green). A riskmetric score should be in [0,1] though, so this issue seems to be an issue of riskmetric ? At least I'm also getting negative scores on my local machine. I filed an issue with them for it -> pharmaR/riskmetric#246

@timtreis timtreis self-assigned this Feb 28, 2022
@timtreis timtreis mentioned this issue Feb 28, 2022
Merged
@timtreis
Copy link
Collaborator Author

Looks like it's an issue of their latest 0.1.2 release. I've now changed our remotes install candidate to the previous 0.1.1 which gives expected output.

@timtreis timtreis reopened this Feb 28, 2022
@timtreis
Copy link
Collaborator Author

The riskmetric team intends to fix this in an upcoming release (pharmaR/riskmetric#242). I'll leave this issue open as a reminder to revert the PR in which we now specify [email protected] once the release candidate of riskmetric is functional again.

@timtreis timtreis added the blocked Issue that can't progress further at this moment label Mar 1, 2022
@timtreis
Copy link
Collaborator Author

timtreis commented Mar 3, 2022

The PR that's supposed to fix the issue is now merged, I'll keep an eye on when the release will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timtreis timtreis

Labels
blocked Issue that can't progress further at this moment bug Something isn't working issue Used for project filtering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP for GH action -> Fixes riskmetric badge openpharma/visR
1 participant
@timtreis