Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSC-STM-A5: Obtain company number from record #244

Open
tiredpixel opened this issue Feb 28, 2024 · 1 comment
Open

PSC-STM-A5: Obtain company number from record #244

tiredpixel opened this issue Feb 28, 2024 · 1 comment
Assignees

Comments

@tiredpixel
Copy link
Contributor

When a record is obtained through the PSC snapshots, it is in the form:

{ company_number: "12345678", data: {} }

However, when read through the PSC Stream API, it is just the data part.

This means the company number will need to be extracted from the data, probably through the psc_self_link.

This will include a research task to check that the company_number from here always matches the self_link identifier.

Estimate: 3 hours

@tiredpixel tiredpixel self-assigned this Apr 19, 2024
@tiredpixel
Copy link
Contributor Author

tiredpixel commented Apr 19, 2024

It appears that PscStream read_stream already extracts the company number, not from the self-link identifier, but from the resource URI:
https://github.com/openownership/register-ingester-psc/blob/main/lib/register_ingester_psc/streams/clients/psc_stream.rb#L36-L38

This seems like a good approach, and it appears to be working correctly. So, there is nothing to do for this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant