Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-timout-in-address-source #2043

Merged
merged 1 commit into from
Aug 29, 2024
Merged

add-timout-in-address-source #2043

merged 1 commit into from
Aug 29, 2024

Conversation

michmuel
Copy link
Collaborator

closes #1875

@michmuel michmuel self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (87b1062) to head (d0e2a57).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2043   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files         120      120           
  Lines        5276     5276           
=======================================
  Hits         4512     4512           
  Misses        764      764           
Flag Coverage Δ
unittests 85.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michmuel michmuel requested review from voisardf and removed request for vvmdipie August 28, 2024 07:26
Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
should we mention the fixed timeout in the doc? at least in the change log I think

@svamaa svamaa merged commit 0ba10cc into master Aug 29, 2024
12 checks passed
@svamaa svamaa deleted the 1875-add-timeout branch August 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swisstopo address source: add timeout?
3 participants