Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide new index attributes #1706

Closed
6 tasks
vvmruder opened this issue Feb 27, 2023 · 3 comments · Fixed by #1753
Closed
6 tasks

Provide new index attributes #1706

vvmruder opened this issue Feb 27, 2023 · 3 comments · Fixed by #1753
Assignees
Labels

Comments

@vvmruder
Copy link
Collaborator

vvmruder commented Feb 27, 2023

Regarding to #1387 (please read also there for more context) we want to implement the attributes in question with the following spec:

  • compare current version of federal defined organization schema model and the pyramid_oereb main schema regarding the attribute AuszugIndex and top up application schema where necessary with attribute extract_index NOT NULL
  • Update the records with the new attribute extract_index
  • Make sure all sources and readers handle it correctly (keep in mind core sources/readers and all the contrib ones)
  • make sure to update import scripts where necessary (especially take care of correct handling of federal data)
  • For rendering (JSON,XML,PDF) this attribute wont be exposed since the extract index is not available in the extract model. We need to handle it as a soft sort index. The elements are sorted after it by the server but are not exposed to any clients. The clients need to respect and NOT CHANGE the sort delivered by server. => This is not the best solution but will work until the extract model is improved by the fed
  • refactor code and tests regardingly
@vvmruder vvmruder added the c2c label Feb 27, 2023
@vvmruder
Copy link
Collaborator Author

vvmruder commented Feb 27, 2023

@jwkaltz may I ask you to provide PSC with a quote for that (the quote will be discussed at the end of march in the user group meeting)?

Let me know if you need further information.

@jwkaltz
Copy link
Member

jwkaltz commented Mar 1, 2023

@jwkaltz may I ask you to provide PSC with a quote for that (the quote will be discussed at the end of march in the user group meeting)?

Let me know if you need further information.

Yes, we will have a look and notify in case of questions.

@mki-c2c
Copy link
Contributor

mki-c2c commented Mar 16, 2023

Hello, I have gotten into preliminary analysis.
I will just share some hypotheses for further development:

  • the new attributes shall be of type NOT NULL in the DB, alright. The import scripts (from FED data are very rigid, so I would rather not modify them but add a constraint on the table, that a sequence generated index is added unless the index is given in the data.
  • if needed, existing databases will be updated with a simple script, instead of a powerful DB migration tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants