-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Improve test #539
Comments
I'm keen to contribute |
@socsieng The easiest one to start with would be the unit test https://github.com/opennextjs/opennextjs-aws/tree/main/packages/tests-unit/tests You need to use pnpm 8 though (pnpm 9 cause some trouble) |
Thoughts about colocating the tests with the code instead of in a separate package? |
Not a big fan at all personally. Separate package makes things a bit cleaner |
I've had a go at just fixing the existing tests: #551 Wanted to confirm that this is what you wanted before proceeding. |
Right now only e2e test work and not everything is properly covered (It's almost impossible to cover everything anyway with e2e given the number of possibilities)
If someone has other ideas on how to improve testing, i'm all ears
The text was updated successfully, but these errors were encountered: