Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Improve test #539

Open
1 of 3 tasks
conico974 opened this issue Oct 10, 2024 · 5 comments
Open
1 of 3 tasks

[Test] Improve test #539

conico974 opened this issue Oct 10, 2024 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@conico974
Copy link
Contributor

conico974 commented Oct 10, 2024

Right now only e2e test work and not everything is properly covered (It's almost impossible to cover everything anyway with e2e given the number of possibilities)

  • Fix the unit test package and integrate it in GH actions
  • We could run a lot more e2e test by running them locally on node
  • Try to cover as much as possible the routing part with unit test

If someone has other ideas on how to improve testing, i'm all ears

@conico974 conico974 added the help wanted Extra attention is needed label Oct 10, 2024
@socsieng
Copy link
Contributor

I'm keen to contribute

@conico974
Copy link
Contributor Author

@socsieng The easiest one to start with would be the unit test https://github.com/opennextjs/opennextjs-aws/tree/main/packages/tests-unit/tests
All the tests here are broken and needs to be ported for OpenNext v3. It's probably easier to just start over.
What we should cover in unit test are all the converters (maybe not the edge one for now), and most of the things in core/routing (not the middleware) that would already be a great start.

You need to use pnpm 8 though (pnpm 9 cause some trouble)

@socsieng
Copy link
Contributor

Thoughts about colocating the tests with the code instead of in a separate package?

@conico974
Copy link
Contributor Author

Not a big fan at all personally. Separate package makes things a bit cleaner

@socsieng
Copy link
Contributor

I've had a go at just fixing the existing tests: #551

Wanted to confirm that this is what you wanted before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants