Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chores] Cleanup the repo #538

Open
6 of 7 tasks
conico974 opened this issue Oct 10, 2024 · 0 comments
Open
6 of 7 tasks

[Chores] Cleanup the repo #538

conico974 opened this issue Oct 10, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@conico974
Copy link
Contributor

conico974 commented Oct 10, 2024 •
edited
Loading

We should take advantage of the new repo to cleanup a bunch of things in this repo to make it cleaner.

  • We can remove everything related to docs here. The new doc is on another repo anyway
  • We should either totally redo the example or just remove it and rely entirely on the different examples repo
  • Globals are defined a bit everywhere right now. We should at least define all the type in a single place with some comment to know where and when they are applied.
  • We could move to biome instead of eslint. It's a lot faster and it is a single dependency
  • Figure out the issue with the lockfile. Using pnpm 9 (with the new lockfile version) breaks almost everything in the repo
  • We could also add syncpack in this repo, it would help a lot with different dependencies and would allow us to lint dep, so that we mostly use fixed version in package.json
  • Update the README
@conico974 conico974 added the help wanted Extra attention is needed label Oct 10, 2024
This was referenced Oct 12, 2024
Closed
Merged
Merged
maxmorozoff added a commit to maxmorozoff/opennextjs-aws that referenced this issue Nov 4, 2024
@maxmorozoff
chore(lint): move to biome instead of eslint (opennextjs#538)
89b7dcb
@maxmorozoff maxmorozoff mentioned this issue Nov 4, 2024
Merged
maxmorozoff added a commit to maxmorozoff/opennextjs-aws that referenced this issue Nov 6, 2024
@maxmorozoff
chore(lint): move to biome instead of eslint (opennextjs#538)
4da249a
conico974 pushed a commit that referenced this issue Nov 8, 2024
@maxmorozoff
chore: configure biome linter (#616)
04379e2 
* chore(lint): move to biome instead of eslint (#538)

* chore(lint): apply biome safe fixes

* chore: add .git-blame-ignore-revs with bulk formatting/linting changes

- Added .git-blame-ignore-revs file to exclude commit b36196d from `git blame`
  to improve readability by ignoring non-functional bulk edits made by Biome formatter and linter.

* chore(lint): disable a11y rules in biome config

* chore(vscode): add biome extension to recommended

* chore(vscode): configure biome as default formatter

* chore(lint): update lint script to include format and import sort checks

* chore: remove .editorconfig in favor of Biome configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@conico974