Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCM-118: Fix NPE scenario i noticed on the qa-refapp server #46

Merged
merged 1 commit into from
Dec 31, 2023
+5 −0
Merged

RCM-118: Fix NPE scenario i noticed on the qa-refapp server #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions omod/src/main/java/org/openmrs/web/controller/report/CohortReportFormController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,17 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
}

private Node findChild(Node parent, String name) {
if (parent == null) {
return null;
}

NodeList list = parent.getChildNodes();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce the level of nesting, why not just do the if parent == null then return early.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like i had done in the first commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tru dat!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

for (int i = 0; i < list.getLength(); ++i) {
Node node = list.item(i);
if (node.getNodeName().equals(name))
return node;
}

return null;
}

Expand Down
Loading