-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For annualised PAGE: control resulting changes in variables #32
Comments
Interpolation issues and considerinations --- Population There are two options here:
N.B. In this change, interpolation happens between years of analysis. However, this is problematic if one would think of the years of analysis to be an average of the period around that year. |
We should take closer looks at some variables, compare the annualised and non-annualised time series and post the results here as well as flag potential bugs.
I just ran the model for the first time in the annualised version and checked only the te_totaleffect variable from EquityWeighting.jl. Compared to the master branch, it dropped by 7%. Besides some deviations due to interpolation, I think a possible reason is that each timestep in the non-annual version represents the years before and after it (e.g. 2150 for 2125-75) but 2300 only represents 2275-2300 because . As impacts should be higher in 2300 than for any previous year, this should lead to upward bias which is corrected by the annualisation.
The text was updated successfully, but these errors were encountered: