subdivision is always required, even when validators.Required unset

[mbehrle]

With the following change subdivision remains required in My Account / Add Address:

diff --git a/trytond_nereid/party.py b/trytond_nereid/party.py
index bd2b146..0d57f6a 100644
--- a/trytond_nereid/party.py
+++ b/trytond_nereid/party.py
@@ -28,9 +28,12 @@ class AddressForm(Form):
streetbis = TextField(('Street (Bis)'))
zip = TextField(('Post Code'), [validators.Required(), ])
city = TextField(_('City'), [validators.Required(), ])

• #country = SelectField(_('Country'), [validators.Required(), ], coerce=int)
• country = SelectField(_('Country'))
• #subdivision = IntegerField(_('State/County'), [validators.Required()])
• subdivision = IntegerField(_('State/County'))

It is quite unusual to select (or even request) the subdivision in some European countries.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[sharoonthomas]

@mbehrle what do you think should be the default ?

1. core module makes the field required and downstream does not.
2. core module makes it optional and downstream modules which need it makes it required

[mbehrle]

• Sharoon Thomas: " Re: [nereid] subdivision is always required, even when
  validators.Required unset (subdivision is always required, even when validators.Required unset #196)" (Sat, 05 Jul 2014 22:16:07 -0700):

@mbehrle what do you think should be the default ?

1. core module makes the field required and downstream does not.
2. core module makes it optional and downstream modules which need it makes
   it required

I would prefer in any case 2, because there are really many countries (if not
all in Europe?), which don't require subdivision.

Of course the best way would be to have it configurable by country, so when you
are making deals with countries needing subdivision in the address format, it
would be required.

Even still better to only display field subdivision, when it is required.

Mathias Behrle
PGP/GnuPG key availabable from any keyserver, ID: 0x8405BBF6