Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public holidays bug on web #73

Closed
damjang opened this issue Feb 24, 2015 · 2 comments
Closed

Public holidays bug on web #73

damjang opened this issue Feb 24, 2015 · 2 comments
Labels
impact: browser type: bug A confirmed report of unexpected behavior.

Comments

@damjang
Copy link

damjang commented Feb 24, 2015

I discover this site and this js and I think that are very good. I go to Italy to check openig_hours but see some errors: e.g. see this have this error:

An error occurred during evaluation of the value "Tu-Fr 09:30-13:00; Sa,PH 10:00-13:00,15:00-19:00". Please file a bug report here: https://github.com/ypid/opening_hours.js/issues?state=open. No holidays are defined for country it. You can also add them: https://github.com/ypid/opening_hours.js

Ok, correct, country It don't have defined PHs. The wrong thing is then if I go to this point in Slovenija the same error appear (No holidays are defined for country it). But if I click to evaluation tool for the same point the country evaluated is correct (Si) so no error. The same error I have also in other countries...

@ypid
Copy link
Member

ypid commented Feb 24, 2015

Thanks for reporting. That has probably to do with the way, the country code is aquired (using reverse geocoding). I will look into this when I have time.

@ypid
Copy link
Member

ypid commented Jun 8, 2015

Bug is in the opening_hours_map. I created an issue there: https://github.com/ypid/opening_hours_map/issues/34

@ypid ypid closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: browser type: bug A confirmed report of unexpected behavior.
Projects
None yet
Development

No branches or pull requests

2 participants