-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: potential leak in retry.go #425
Labels
bug
Categorizes issue or PR as related to a bug.
Comments
Can you add more descriptive information, such as a complete title? |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
luhaoling
added a commit
to luhaoling/open-im-server
that referenced
this issue
Mar 5, 2024
* fix: fix the component check logic * fix: add graceful_exit in admin-api * fix: fix the graceful exit logic * fix: add rpc graceful logic * fix: del the http port * fix: add graceful logic in chat-api * fix: update the func location * Before starting the script, first check if the program has exited * fix: fix the error * fix: fix the error * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * fix: test the func loc * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * fix: fix the tools version * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * Before starting the script, first check if the program has exited * ComponentCheck timeout * component check timeout * fix: update the component check * fix: update the component check logic * component check timeout * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check * component check --------- Co-authored-by: luhaoling <[email protected]> Co-authored-by: Brabem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
I notice the ctx.Done() needs a cancel function to unblock the statement of ctx.Done in https://github.com/OpenIMSDK/Open-IM-Server/blob/main/pkg/tools/retry/retry.go#LL162C20-L162C20,
but I never find the cancel function in its invocation. So if this may leak the goroutine where the ctx.Done() locates?
Maybe what I said is not right, thank you for taking a look.
What did you expect to happen?
.
How can we reproduce it (as minimally and precisely as possible)?
.
Anything else we need to know?
.
version
Cloud provider
OS version
Install tools
The text was updated successfully, but these errors were encountered: