Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string utils in core #3783

Closed
lsiepel opened this issue Aug 27, 2023 · 0 comments · Fixed by #3738
Closed

Add string utils in core #3783

lsiepel opened this issue Aug 27, 2023 · 0 comments · Fixed by #3738
Labels
enhancement An enhancement or new feature of the Core

Comments

@lsiepel
Copy link
Contributor

lsiepel commented Aug 27, 2023

Most apache common libs have been removed from addons, but there are some left. Last months, i have been fixing several and would like to finish the remaining ones.

While doing so, i had PR feedback that multiple bindings use the same string utillity methods and it would be better to add it to core so code duplication is prevented. This core PR: #3738 is pending.

Issue: openhab/openhab-addons#15349 is keeping track of the remaining addons that can be fixed by this. I will update existing and create new PR's when #3738 is merged.

Would be nice if a @openhab/core-maintainers can comment
@lsiepel lsiepel added the enhancement An enhancement or new feature of the Core label Aug 27, 2023
@lsiepel lsiepel changed the title Add strin gutils in core Add string utils in core Aug 27, 2023
@lsiepel lsiepel mentioned this issue Aug 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add string utils to core lsiepel/openhab-core
1 participant
@lsiepel