Thing actions should have a unique id

[lolodomo]

Bindings sometimes define several thing actions with the same method name leading to thing actions having the same id. It should be fixed. openhab/openhab-core#4438 allows defining action id not depending on method name and as a consequence allows avoidding thing actions with the same id when the same method name is used.

Bindings to be fixed:

• chromecast (playURL) => PR [chromecast] Assign unique id to thing actions #17708
• ecobee (setHold) => PR [ecobee] Assign unique id to thing actions #17709
• energidataservice => PR [energidataservice] Fix @ActionOutput annotations #17679
• enigma2 => PR [enigma2] Assign unique id to thing actions #17710
• lgwebos => PR [lgwebos] Assign unique id to thing actions #17712
• mpd (sendCommand) => PR [mpd] Assign unique id to thing actions #17711
• mqtt (publishMQTT)
• ...

All bindings from a until m were checked

[lolodomo]

I realise that the id, when it is not the method name, should be mentioned in the documentation as this id is required to run the REST API (run the action).

[Laith-Budairi]

is there still a need to do the mqtt binding too?

[lsiepel]

is there still a need to do the mqtt binding too?

There is another PR in core that generates these id’s automatically. So this makes the live of contributors and maintainers a little easier as we do not need to care about the id in the bindings.

[lolodomo]

The need disappeared with the enhancement in progress in core framework.
But the discussion in the core PR revealed another issue that should be fixed in bindings: you must not define several classes with the same action scope. I know for example caddx or freeboxos doing that.
@J-N-K explained this constraint.

[lolodomo]

I am know closing th me issue as the core PR fixing the problem has been merged.