Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Modal components have wrong padding #447

Open
seaerchin opened this issue Jul 25, 2023 · 1 comment
Open

[BUG] Modal components have wrong padding #447

seaerchin opened this issue Jul 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@seaerchin
Copy link

Describe the bug
Modal components have padding that does not adhere to the figma.

To Reproduce
Steps to reproduce the behavior:

  1. create a barebones Modal with the following components: modal content, button, header, footer
  2. Observe that ModalCloseButton, ModalFooter and ModalHeader have wrong padding.

Expected behavior
The padding should be correct
@NatMaeTan
Copy link

NatMaeTan commented Jul 31, 2023 •
edited
Loading

Piggybacking on this issue,

  1. Close icon is also inconsistent with figma, looks skinnier than our boxicon

  2. Clear 'Cancel' button should be in the neutral variant, currently is in brand colors

Per chin's comment, Footer padding should be 40px above and below the button group

@NatMaeTan NatMaeTan added the bug Something isn't working label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seaerchin @NatMaeTan