Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mask ids in react svgr components generated by SVGR #278

Open
karrui opened this issue Mar 9, 2023 · 1 comment
Open

fix mask ids in react svgr components generated by SVGR #278

karrui opened this issue Mar 9, 2023 · 1 comment

Comments

@karrui
Copy link
Collaborator

karrui commented Mar 9, 2023

Most (if not all) of our SVG React components are generated with SVGR.
Using SVGR generates ids to the mask groups inside the given SVG, which are extremely likely to clash if there are two SVGRs in the same html layout, resulting in the later declaration of id properties to be used for the wrong SVGs.

We should take a look at all the SVG React components to name the mask ids to something less likely to clash.

See related issue in opengovsg/FormSG#5749

@karrui
Copy link
Collaborator Author

karrui commented Jun 14, 2023

Will regenerate all SVGR generated icons with SVGO option cleanupIds set to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant