Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable support for allowing sorting over fields not explicitly mentioned in /sortables #153

Closed
philvarner opened this issue Oct 12, 2021 · 4 comments
Assignees

Comments

@philvarner
Copy link

The Queryables mechanism in CQL support uses a field additionalProperties to indicate that the server allows values to be requested that are not explicitly defined as queryables. This should also be applied to the Sortable specification, so a client may request sorting on a property that may not exist on any or all of the result entities and is not explicitly defined as a sortable field in the .../sortables endpoints.

@pvretano
Copy link
Contributor

@philvarner the sortables stuff is directly derived from the queryables stuff (same schema I think) so yes, it will inherit additionalProperties=true. The link to the sortables schema in the document seems to be broken at the moment but I will fix that and verify.

@philvarner
Copy link
Author

@pvretano ah, great. It would be nice to have something about that in the text also, since (now that I searched for it) it seems to only be described by the schemas.

@pvretano
Copy link
Contributor

29-NOV-2021: The SWG agree with @philvarner and as mentioned, the sortables are derived from the queryables stuff so additionaProperty=true is already there. A related issues #126 mentions that we are moving the API stuff of records (q, sortables, etc.) to features.

@pvretano pvretano self-assigned this Dec 7, 2021
@pvretano
Copy link
Contributor

pvretano commented Feb 7, 2022

07-FEB-2022: The issue has been answered the question (i.e. additionalProperties=true is inherited from the queryables schema) and also referenced the issue that is moving q and sortby to features.

@pvretano pvretano closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants