You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We added the application models in "lib-components" by convenience, because some components use them, they shouldn't (circular dependency) and it is not the place of these models, they should be in their own packages: apps-model
Solution
Refactorize the components in lib-component using the apps models to not use them anymore.
Then move back the models in their correct place, apps/classroom/models.ts should be in lib-classroom package.
Ex: UploadManager could have a prop isWithContentType, like that the component will be free of apps model dependency.
The text was updated successfully, but these errors were encountered:
Problem
We added the application models in "lib-components" by convenience, because some components use them, they shouldn't (circular dependency) and it is not the place of these models, they should be in their own packages: apps-model
Solution
lib-component
using the apps models to not use them anymore.apps/classroom/models.ts
should be inlib-classroom
package.Ex:
UploadManager could have a prop
isWithContentType
, like that the component will be free of apps model dependency.The text was updated successfully, but these errors were encountered: