chore: Upgrades dependencies #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebaldi
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Hi @akoenig,
the change lgtm. I added a remark regarding the license text. I think it's good to have the proprietary passage removed since that was in conflict with the license stated in the package manifest.
Now I think we're in a gray area, because we have that license reference but no explicit license text anywhere in the repo. Yet, I also think it's fine to handle this separately.
| @@ -131,5 +131,3 @@ The project is using [commitizen](https://github.com/commitizen/cz-cli) for ensu | |||
| ## 👩🏽⚖️ Copyright | |||
|
|
|||
| Copyright (C), 2021 Open Formation GmbH – Hamburg – Germany All Rights Reserved | |||
There was a problem hiding this comment.
There should be a full version of the MIT license text at the repository root, since the package.json states MIT as its license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades dependencies.