Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer listing: Images covering text (on google pixel, chrome) #47

Open
kirstenalarsen opened this issue Apr 17, 2024 · 7 comments
Open
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.

Comments

@kirstenalarsen
Copy link

Image

@kirstenalarsen
Copy link
Author

they're back

@github-project-automation github-project-automation bot moved this from Ready for dev to Done in Discover Regenerative Apr 17, 2024
@mariocarabotta
Copy link

they're back

what do you mean?

logos are still overlapping in my phone

@mariocarabotta mariocarabotta moved this from Done to Ready for dev in Discover Regenerative Apr 17, 2024
@mariocarabotta mariocarabotta removed their assignment Apr 22, 2024
@mariocarabotta mariocarabotta added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. and removed bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. labels Apr 22, 2024
@mariocarabotta
Copy link

temporarily fixed in WP css by modifying the style below

@media only screen and (max-width: 700px) {
[name=set-card-panel] [name=set-right-panel] [name=set-title] {
margin-left: 110px;
}
}

@mariocarabotta
Copy link

the above solution is not good enough. it looks like logos are not positioned all at the same height, causing some weird overlap in some cards:

Image
Image
Image

@JbPasquier
Copy link

Same as before, this come from your wordpress style rules.

font-size: var(--wp--preset--font-size--medium);

I'll force some style within the component.

@mariocarabotta
Copy link

this is happening in the component test environment as well.
anyway, I'm moving it back to after launch, it's sort of good enough for now.

@mariocarabotta mariocarabotta moved this from Ready for dev to Design / Planning / Estimate in Discover Regenerative May 2, 2024
@kirstenalarsen kirstenalarsen moved this from Design / Planning / Estimate to Todo in Discover Regenerative Jun 19, 2024
@kirstenalarsen kirstenalarsen moved this from Todo to Design / Planning / Estimate in Discover Regenerative Jun 19, 2024
@mariocarabotta mariocarabotta moved this from Design / Planning / Estimate to Todo in Discover Regenerative Jun 19, 2024
@mariocarabotta mariocarabotta moved this from Todo to Ready for dev in Discover Regenerative Jul 2, 2024
@mariocarabotta
Copy link

for future work, before fixing this at the component style level, the code here needs to be removed from WP css.

@mkllnk mkllnk added this to the SiB Fixes round 1 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted.
Projects
Status: Ready for dev
Development

No branches or pull requests

4 participants