-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citi OFN Vouchers] As a shopper I can use a voucher created with VINE #12859
Comments
@RachL a few questions :
FYI I am going over the estimated time, I realised there are a few scenarios where we need to redeem the voucher other than the normal checkout which I missed in my estimation. |
@rioug I'm still unsure how it will look like but I remember Kirsten saying the list of vouchers could end up being pretty long. If so, that would be a strong argument for not listing them on OFN. So let's keep them out for now, and if there is a need in the future we can display them.
Do you mean on the checkout page? In this case I think a generic message is enough, the shopper does not need to know the type of voucher. |
I meant when adding a voucher to the order, the VINE Api can return an "Invalid voucher" error, ie: it has established the voucher exist in VINE but it's invalid for some reason. I am wondering if we should tell the customer so they can potentially tell whoever gave them the voucher that there is an issue. |
I spent 49.59 hours on this |
New requirement :
|
@RachL
Redeeming a voucher can fail for multiple reasons, from the VINE Api:https://github.com/openfoodfoundation/vine/blob/1ec4970b94c3550880e7c3067bf8baf9da62b290/app/Http/Controllers/Api/V1/ApiVoucherRedemptionsController.php#L64-L93 |
Description
- As a: a shopper
- On page: payment method step at checkout
- I want to be able to do:
A voucher issued through VINE should work the same as an OFN voucher for the shopper experience:
For the hub: all reports handling vouchers are updated accordingly.
the system should first check the OFN vouchers database before the VINE one.
Acceptance Criteria & Tests
Estimations
For context this is the current voucher "life cycle" :
When a customer enter a voucher code :
VINE voucher "life cycle" :
Assumption:
Tasks:
Total : 2 -2.5 days , add 20% to cover unforeseen issue
Estimation total: 2.4 - 3 days
The text was updated successfully, but these errors were encountered: