Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display ordering in shopfront field too tight to allow re-ordering of the sequence #12852

Closed
tschumilas opened this issue Sep 9, 2024 · 1 comment · Fixed by #12860
Closed
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue Hacktoberfest Issues for upcoming hackathons

Comments

@tschumilas
Copy link

Description

In the new admin interface, the display ordering by shopfront field (in Shop Preferences in the enterprise settings) does not provide enough room for the user to effectively order the shop display by category or by producer.

Expected Behavior

This setting is used by shop managers to control the appearance of the shopfront (ie the order in which categories are displayed, or the order in which producers area displayed). The fields should have sufficient space to allow for this ordering.

Actual Behaviour

The new interface space is too tight and its difficult to fit in two or more lines of categories or producers.

Steps to Reproduce

  1. For an enterprise that is either 'sells own' or 'sells any' - go to the enterprise setting: shop preferences
  2. See the Display ordering in the shopfront setting.

Animated Gif/Screenshot

image

Workaround

No workaround - user has to 'guess' a bit at what the categories or producers are.

Severity

S4

bug-s1: a critical feature is broken: checkout, payments, signup, login
bug-s2: a non-critical feature is broken, no workaround
bug-s3: a feature is broken but there is a workaround
bug-s4: it's annoying, but you can use it
bug-s5: we can live with it, only a few users impacted

https://github.com/openfoodfoundation/openfoodnetwork/wiki/Bug-severity
-->

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Sep 9, 2024
@sigmundpetersen sigmundpetersen added the bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. label Sep 9, 2024
@github-project-automation github-project-automation bot moved this to To triage (By the maintainers) in Welcome New Developers! Sep 9, 2024
@RachL RachL added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. and removed bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. labels Sep 10, 2024
@RachL RachL added this to the [BUU2] Product List uplift milestone Sep 11, 2024
@chahmedejaz chahmedejaz self-assigned this Sep 11, 2024
@chahmedejaz
Copy link
Collaborator

The display issue of the fields has been fixed such that it will be displaying all the selected choices. Here's the screenshot:
image

However, I noticed that in the new screen remove option was not implemented as you can also see in the above screenshot. This has also been implemented in the fix for this issue. Here:
image

@sigmundpetersen sigmundpetersen moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Sep 14, 2024
@RachL RachL added the Hacktoberfest Issues for upcoming hackathons label Sep 24, 2024
@RachL RachL moved this from To triage (By the maintainers) to In progress in Welcome New Developers! Oct 1, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Welcome New Developers! Oct 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress ⚙ to Done in OFN Delivery board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue Hacktoberfest Issues for upcoming hackathons
Projects
Status: Done
4 participants