Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Knowledge Panel page: bg color in light mode + product name #5920

Merged
merged 1 commit into from
Nov 24, 2024
Merged

fix: Knowledge Panel page: bg color in light mode + product name #5920

merged 1 commit into from
Nov 24, 2024
+14 −1

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 24, 2024

Hi everyone!

Here are two enhancements for the KP details page:

  • In light mode, the background color is the same as the product page
  • In all configs, in the header, we now display the product name

KP

@g123k g123k linked an issue Nov 24, 2024 that may be closed by this pull request
The color contrast between the card and the background is not the same in List views, and sub knowledge panel, as in the product page #5910
Open
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 6.60%. Comparing base (4d9c7fc) to head (8b101ac).
Report is 509 commits behind head on develop.

Files with missing lines Patch % Lines
...e_panel/knowledge_panels/knowledge_panel_page.dart 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop   #5920      +/-   ##
==========================================
- Coverage     9.54%   6.60%   -2.95%     
==========================================
  Files          325     436     +111     
  Lines        16411   24541    +8130     
==========================================
+ Hits          1567    1621      +54     
- Misses       14844   22920    +8076

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

teolemon
teolemon approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@teolemon teolemon merged commit 453bf9e into openfoodfacts:develop Nov 24, 2024
6 checks passed
@g123k g123k deleted the kp_header branch November 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@g123k g123k

Labels
None yet
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🎊 Done
Milestone
No milestone
3 participants
@g123k @codecov-commenter @teolemon