Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addressed all linting errors #80

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: Addressed all linting errors #80

merged 1 commit into from
Oct 5, 2023

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Oct 5, 2023

Description

  • Copied configuration from syntax transformer
  • Ignored lines complaining about missing vscode lib as it doesnt exist until run
  • Left some warnings to revist

References

closes #63

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery marked this pull request as ready for review October 5, 2023 19:27
@d-jeffery d-jeffery requested a review from a team as a code owner October 5, 2023 19:27
@adriantam adriantam added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 1703a50 Oct 5, 2023
4 checks passed
@adriantam adriantam deleted the fix/linting branch October 5, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eslint and add a CI job that fails if eslint fails
2 participants