Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e tests working for node and web #77

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: e2e tests working for node and web #77

merged 1 commit into from
Oct 3, 2023

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Oct 3, 2023 •
edited
Loading

Description

  • Added env var VSCODE_TEST_NODE to dictate which file system structure to use whether in node or browser for the test suite. When set,VSCODE_TEST_NODE will use file, otherwise it uses vscode-test-web for browser.
  • Changed github workflow to use npm test to run both node and web tests on a PR

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery force-pushed the fix/e2e-tests branch 5 times, most recently from b15b64f to 69154ac Compare October 3, 2023 20:34
@d-jeffery d-jeffery requested review from rhamzeh and adriantam and removed request for rhamzeh October 3, 2023 20:38
@d-jeffery d-jeffery marked this pull request as ready for review October 3, 2023 20:38
@d-jeffery d-jeffery requested a review from a team as a code owner October 3, 2023 20:38
adriantam
adriantam previously approved these changes Oct 3, 2023
View reviewed changes
client/src/test/index.browser.ts Outdated Show resolved Hide resolved
@adriantam adriantam added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 65e8b9e Oct 3, 2023
4 checks passed
@adriantam adriantam deleted the fix/e2e-tests branch October 3, 2023 21:31
@d-jeffery d-jeffery mentioned this pull request Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @adriantam