Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to latest syntax-transformer #64

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat: update to latest syntax-transformer #64

merged 1 commit into from
Sep 21, 2023

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Sep 21, 2023 •
edited
Loading

Description

Updated to latest @openfga/syntax-transformer beta, containing validation

Latest manual build:
openfga-vscode-0.2.0.vsix.zip

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery marked this pull request as ready for review September 21, 2023 20:24
@d-jeffery d-jeffery requested a review from a team as a code owner September 21, 2023 20:24
@d-jeffery d-jeffery force-pushed the fix/duplicate-error-bug branch 2 times, most recently from 2a69fc7 to 727f434 Compare September 21, 2023 20:40
adriantam
adriantam reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@adriantam adriantam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we need to update release notes?
  2. Should it be 0.1.1 or 0.2.0?

@adriantam
Copy link
Member

  1. Do we need to update release notes?
  2. Should it be 0.1.1 or 0.2.0?

Ah...see that we have not bumped

@d-jeffery
Copy link
Collaborator Author

d-jeffery commented Sep 21, 2023 •
edited
Loading

  1. Do we need to update release notes?
  2. Should it be 0.1.1 or 0.2.0?

Ah...see that we have not bumped

I rolled back the bump. Opinion is 0.2.0 if following semantic versioning.

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

And yeah, we should add release notes for this one.

@adriantam adriantam merged commit 5893787 into main Sep 21, 2023
4 checks passed
@adriantam adriantam deleted the fix/duplicate-error-bug branch September 21, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

@rhamzeh rhamzeh Awaiting requested review from rhamzeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @adriantam