Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #147

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Minor fixes #147

merged 3 commits into from
Nov 8, 2024

Conversation

ewanharris
Copy link
Member

Description

This PR fixes some minor issues I noticed while updating the openfga/api sha on `main. Splitting out to a separate PR to help review.

They are as follows:

  • the ListUsers API differs on the shape of contextual_tuples, rather than an object with a tuple_keys property it just takes the array directly. So we don't need the ContextualTupleKeys type
  • read_latest_authorization_model errors if there are no models
  • list_users in the example was using the wrong types

References

openfga/sdk-generator#446

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@ewanharris ewanharris requested a review from a team as a code owner November 5, 2024 17:36
@ewanharris ewanharris changed the title Fix/minor fixes Minor fixes Nov 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (e49a77a) to head (8905252).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   69.17%   69.15%   -0.02%     
==========================================
  Files         122      122              
  Lines        9751     9753       +2     
==========================================
  Hits         6745     6745              
- Misses       3006     3008       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 9c3a4b1 Nov 8, 2024
17 checks passed
@ewanharris ewanharris deleted the fix/minor-fixes branch November 8, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants