Plan: Make Task Runner Drupal agnostic

[claudiu-cristea]

Problem

Task Runner provides default commands but some of them are Drupal-specific commands. In fact Task Runner it's not supposed to be a "Drupal tool" but a generic command runner. For this reason, the Drupal specific commands should be moved outside, in their own repo, i.e. openeuropa/task-runner-drupal.

However, this might impact some projects that are using Task Runner, mainly the Toolkit project. Currently, Toolkit uses or overrides some of the Task Runner default commands as follows:

• drupal:settings-setup: Overridden,
• drupal:permissions-setup: Used,
• drupal:site-install: Used,

The problem is with the current drupal:settings-setup command. This can be overridden by Toolkit because the Task Runner version is registered before the namespace discovered commands. If we move the Task Runner version in a 3rd party library, we cannot guarantee which version will be discovered first and the Toolkit override might not work. But we want to guarantee that Toolkit is able to override the Task Runner version.

Proposal

For this reason, we propose the following strategy:

• Move Drupal commands in a new project #131 in branch 1.x

• Move all Drupal commands in a new project: openeuropa/task-runner-drupal.
• In openeuropa/task-runner-drupal, rename drupal:settings-setup as drupal:setup-settings (or drupal:build-settings, drupal:settings?).
• Add openeuropa/task-runner-drupal as Composer dependency to openeuropa/task-runner, so that third-party that are updating their Task Runner version will continue to have available the Drupal commands.
• Keep the drupal:settings-setup as default command, so that is guaranteed that Toolkit can override it as it does now but remove the command body and replace it with a call to the openeuropa/task-runner-drupal method.
• Add a [deprecated] prefix to the drupal:settings-setup command description.
• Trigger a muted user deprecation error from the Task Runner's drupal:settings-setup command:

  The 'drupal:settings-setup' command is deprecated in openeuropa/task-runner:1.0.0 and will be removed in openeuropa/task-runner:2.0.0. Use the 'drupal:setup-settings' command instead.
  

• Move all other default commands under a normal namespace, but inside openeuropa/task-runner.

• Move 'changelog:generate' command in a separate project #133 in branch 1.x

• Move changelog:generate in a new openeuropa/task-runner-changelog repository.
• Depend on openeuropa/task-runner-changelog for BC reasons.

• Move 'release:create-archive' command in a separate project #134 in branch 1.x

• Move release:create-archive in a new openeuropa/task-runner-artifact repository.
• Depend on openeuropa/task-runner-artifact for BC reasons.

• [2.x] Remove deprecated command. Decouple external commands #132 in branch 2.x

• Remove the dependencies to openeuropa/task-runner-drupal, openeuropa/task-runner-changelog and openeuropa/task-runner-artifact from openeuropa/task-runner. Third party, such as Toolkit, will have to explicitly add these dependencies if they requires them.
• Remove the drupal:settings-setup command together with the concept of default commands.

[ademarco]

Proposal look good, only we need to make sure that whatever we do in 1.x does not require any manual fix on libraries that depends on it, such as the Toolkit, but I guess that's what you meant by:

Keep the drupal:settings-setup as default command, so that is guaranteed that Toolkit can override it as it does now but remove the command body and replace it with a call to the openeuropa/task-runner-drupal method.

About:

Are changelog:generate and release:create-archive Task Runner core commands or we should move them out, somewhere (where?)?

We could create two new repos:

• openeuropa/task-runner-changelog
• openeuropa/task-runner-artifact (archive actually refers to that, as in: to the possibility to create artifacts)

[claudiu-cristea]

we need to make sure that whatever we do in 1.x does not require any manual fix on libraries that depends on it, such as the Toolkit, but I guess that's what you meant by:

Yes, the Toolkit will not be affected.

We could create two new repos:

Great! This add more clarity to the whole ecosystem. I will create 2 new tickets.

@ademarco Could you, please, create the 3 new repos with the same perms as this one?

[ademarco]

Yep, will do!