-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCL builder] Make postcss prefixer option more flexible #591
Labels
enhancement
New feature or request
Comments
ok, i am going to recreate the same pr on bcl directly, the solution seems good on my side |
Why? Personally I don't mind but this isn't promoting contributions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
BCL builder allows passing the
prefix
option when compiling sass files, but it is not flexible enough as it only passes the prefix and not the entirepostcss-prefix-selector
config which we would need.Also, the plugin gets run with an empty prefix when no prefix are specified, which I believe is slowing down the compilation for no reason. And the current transform callback is not necessary and optional.
Context:
We would need such feature/flexibility for ckeditor5 stylesheets which expects all CSS to be prefixed with ".ck-content", but we need to specify the transform callback to deal with ":root".
Also relates to openeuropa/oe_bootstrap_theme#404
To be:
Proposed resolution
Deprecate the
prefix
option in favor ofprefixer
which holds the entire prefixer config.Run the plugin only when one of these options is passed.
The text was updated successfully, but these errors were encountered: