Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise egoio.db.connection() #80

Open
gplssm opened this issue Aug 29, 2019 · 0 comments
Open

Revise egoio.db.connection() #80

gplssm opened this issue Aug 29, 2019 · 0 comments

Comments

@gplssm
Copy link
Contributor

gplssm commented Aug 29, 2019

The entire function connection() is a bit clumpsy and hampers easy integration/extension of its functionality. I would suggest to make a minor release (i.e. v0.5.0) which breaks the convention of this function and provides a cleaned up interface for

  • config file
  • manual config by parameters
  • easy passwordless

And, I would would suggest to rename the function to engine(), since it returns an engine.
Maybe this allows to retain the old function connection() for some time to warn about deprecation and remove it later.

nesnoj added a commit that referenced this issue Aug 29, 2019
with the next release, a minor change of db.connection() is planned, cf. #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant