Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] OpenEdX app shows a banner to download edX app #220

Closed
sergeymomot opened this issue Jan 8, 2024 · 0 comments · Fixed by #246
Closed

[iOS] OpenEdX app shows a banner to download edX app #220

sergeymomot opened this issue Jan 8, 2024 · 0 comments · Fixed by #246
Assignees
@rnr

Comments

@sergeymomot
Copy link

sergeymomot commented Jan 8, 2024 •
edited
Loading

Our app shows a banner to download edX app inside the content . Can we not show it?
https://learning.stage.edx.org/course/course-v1:aqdasss22+aqd012+123123/block-v1:aqdasss22+aqd012+123123+type@sequential+block@ec3364075f2845baa625bfecd5970410/block-v1:aqdasss22+aqd012+123123+type@vertical+block@7f24ea75d92a469e89d24964424d35a3

d21e1fd8-de2d-4f93-8cf5-6251d8b79195
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-08.at.21.00.04.mp4
@rnr rnr self-assigned this Jan 22, 2024
@rnr rnr moved this to In Development in Open edX Mobile Roadmap Jan 22, 2024
@rnr rnr mentioned this issue Jan 22, 2024
Merged
@rnr rnr moved this from In Development to In Code Review / Final Acceptance in Open edX Mobile Roadmap Jan 22, 2024
@rnr rnr linked a pull request Jan 22, 2024 that will close this issue
Add custom user agent to hide app banner on web page #246
Merged
@rnr rnr moved this from In Code Review / Final Acceptance to Done in Open edX Mobile Roadmap Jan 25, 2024
@rnr rnr closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnr rnr

Labels
None yet
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom user agent to hide app banner on web page edx/edx-mobile-marketplace-ios
2 participants
@rnr @sergeymomot