feat: reduce unnecessary api calls #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/reduce-api-calls
branch
from
be40480 to
56b3935
Compare
zacharis278
commented
Jan 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 94.13% 94.14%
=======================================
Files 71 71
Lines 1058 1059 +1
Branches 289 290 +1
=======================================
+ Hits 996 997 +1
Misses 57 57
Partials 5 5 ☔ View full report in Codecov by Sentry. |
MichaelRoytman
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every sequence navigation renders a new ExamWrapper component causing us to hit the
/latestendpoint every time. We really only need to do this in a few cases.If the store already has a latest exam there's no reason to keep checking it on every user navigation, the polling function will already take care of refreshing data. I expect this change to drastically reduce the number of API calls we're generating.