Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update checkApp origin requirement #126

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Dec 12, 2023

The proctorio extension running the exam will use a url on the exams service instead of the MFE url.

More details in edx/edx-exams#227

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a04fbf) 94.10% compared to head (b1f6ae0) 94.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          71       71           
  Lines        1051     1051           
  Branches      289      289           
=======================================
  Hits          989      989           
  Misses         57       57           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278 zacharis278 force-pushed the zhancock/exam-domain-check branch from 42e420f to 2252269 Compare December 12, 2023 19:55
@zacharis278 zacharis278 changed the title feat: remove checkApp origin requirement feat: update checkApp origin requirement Dec 12, 2023
@zacharis278 zacharis278 force-pushed the zhancock/exam-domain-check branch from 2252269 to c6342ec Compare December 15, 2023 19:14
@zacharis278 zacharis278 force-pushed the zhancock/exam-domain-check branch from c6342ec to b1f6ae0 Compare December 15, 2023 19:17
Copy link
Contributor

@alangsto alangsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zacharis278 zacharis278 merged commit 1d236a4 into main Dec 15, 2023
7 checks passed
@zacharis278 zacharis278 deleted the zhancock/exam-domain-check branch December 15, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants