Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update studio header to be more accessible #403

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

KristinAoki
Copy link
Member

Update studio header to use paragon icons and dropdowns. The previous version of the header relied relied on custom components that did not allow for keyboard navigation.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a60748) 61.25% compared to head (9f48ccc) 66.86%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   61.25%   66.86%   +5.60%     
==========================================
  Files          16       25       +9     
  Lines         302      338      +36     
  Branches       70       78       +8     
==========================================
+ Hits          185      226      +41     
+ Misses        115      110       -5     
  Partials        2        2              
Files Coverage Δ
src/studio-header/BrandNav.jsx 100.00% <100.00%> (ø)
src/studio-header/CourseLockUp.jsx 100.00% <100.00%> (ø)
src/studio-header/HeaderBody.jsx 100.00% <100.00%> (ø)
src/studio-header/MobileHeader.jsx 100.00% <100.00%> (ø)
src/studio-header/MobileMenu.jsx 100.00% <100.00%> (ø)
src/studio-header/NavDropdownMenu.jsx 100.00% <100.00%> (ø)
src/studio-header/StudioHeader.jsx 100.00% <100.00%> (ø)
src/studio-header/UserMenu.jsx 100.00% <100.00%> (ø)
src/studio-header/messages.js 100.00% <100.00%> (ø)
src/studio-header/utils.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki force-pushed the KristinAoki/update-studio-header branch from fd84bd8 to 9f48ccc Compare October 2, 2023 14:06
@KristinAoki KristinAoki merged commit 2298791 into master Oct 2, 2023
6 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/update-studio-header branch October 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants