feat!: remove Transifex calls for OEP-58 | FC-0012 #416

hopewise · 2023-10-21T09:12:53Z

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

Removes all direct use of tx pull and tx push commands from the micro-frontend in favor
of the atlas pull command.
Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
Remove all Transifex related Makefile targets and other files.

Test results

Verify that make pull_translations works as expected.

make pull_translations test results

# I've run the following commands:
$ make requirements
$ make pull_translations
$ git diff

# Output of the commmands:

make pull_translations
rm -rf src/i18n/messages
mkdir src/i18n/messages
cd src/i18n/messages \
      && atlas pull \
               translations/paragon/src/i18n/messages:paragon \
               translations/frontend-component-header/src/i18n/messages:frontend-component-header \
               translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
               translations/frontend-app-profile/src/i18n/messages:frontend-app-profile
Pulling translation files
 - directory: translations/paragon/src/i18n/messages:paragon translations/frontend-component-header/src/i18n/messages:frontend-component-header translations/frontend-component-footer/src/i18n/messages:frontend-component-footer translations/frontend-app-profile/src/i18n/messages:frontend-app-profile
 - repository: openedx/openedx-translations
 - branch: main
 - filter: Not Specified
 - expand-glob: Not Specified
Creating a temporary Git repository to pull translations into "./translations_TEMP"...
Done.
Setting git sparse-checkout rules...
Done.
Pulling translation files from the repository...
remote: Enumerating objects: 58, done.
remote: Counting objects: 100% (58/58), done.
remote: Compressing objects: 100% (32/32), done.
remote: Total 58 (delta 38), reused 39 (delta 26), pack-reused 0
Receiving objects: 100% (58/58), 49.75 KiB | 191.00 KiB/s, done.
Resolving deltas: 100% (38/38), done.
Updating files: 100% (58/58), done.
Your branch is up to date with 'origin/main'.
Done.
Copying translations from "./translations_TEMP/translations/paragon/src/i18n/messages" to "./paragon"...
Done.
Copying translations from "./translations_TEMP/translations/frontend-component-header/src/i18n/messages" to "./frontend-component-header"...
Done.
Copying translations from "./translations_TEMP/translations/frontend-component-footer/src/i18n/messages" to "./frontend-component-footer"...
Done.
Copying translations from "./translations_TEMP/translations/frontend-app-profile/src/i18n/messages" to "./frontend-app-profile"...
Done.
Removing temporary directory...
Done.

Translations pulled successfully!
paragon frontend-component-header frontend-component-footer frontend-app-profile
make: paragon: No such file or directory
make: *** [pull_translations] Error 1

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

Keep this pull request as a draft to prevent accidental merge.

Pre-merge checklist

Wait for approval on Deprecate pre-OEP-58 Transifex scripts from all repositories wg-translations#20

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks · 2023-10-21T09:12:59Z

Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d · 2023-10-24T14:31:03Z

@hopewise looks like there are some test failures.

brian-smith-tcril · 2023-10-26T16:05:49Z

src/i18n/index.js

-};
-
-export default messages;
+export default [];


Suggested change

export default [];

export default [];

This should fix the lint error

Thanks @brian-smith-tcril , new line got added.

codecov · 2023-10-28T14:02:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (3b2a2bf) to head (6cfe121).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   66.96%   66.86%   -0.10%     
==========================================
  Files          25       24       -1     
  Lines         339      338       -1     
  Branches       78       78              
==========================================
- Hits          227      226       -1     
  Misses        110      110              
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OmarIthawi · 2023-10-28T20:42:39Z

Makefile

-	# Pushing comments to Transifex...
-	./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh
-
-# Pulls translations from Transifex.
 pull_translations:


Please remove the pull_translations step without atlas pull.

Components like Paragon, footer and header don't need atlas pull.

OmarIthawi · 2023-10-28T20:42:56Z

src/i18n/index.js

-import hiMessages from './messages/hi.json';
-import frCAMessages from './messages/fr_CA.json';
-// no need to import en messages-- they are in the defaultMessage field
+export default [];


Please fix the newlines.

OmarIthawi

@timmc-edx this one is ready, but pending 2U approval.

cc: @itsjeyd @brian-smith-tcril

openedx-webhooks · 2024-03-22T17:08:12Z

@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 21, 2023

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 23, 2023

OmarIthawi mentioned this pull request Oct 24, 2023

Deprecate pre-OEP-58 Transifex scripts from all repositories openedx/wg-translations#20

Closed

1 task

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023

brian-smith-tcril reviewed Oct 26, 2023

View reviewed changes

hopewise force-pushed the samir/frontend-component-header branch 2 times, most recently from 2aaf085 to 8547936 Compare October 28, 2023 14:00

OmarIthawi reviewed Oct 28, 2023

View reviewed changes

itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Nov 2, 2023

itsjeyd removed the blocked by other work PR cannot be finished until other work is complete label Feb 23, 2024

hopewise marked this pull request as ready for review March 14, 2024 07:11

OmarIthawi force-pushed the samir/frontend-component-header branch 2 times, most recently from b022066 to 4357c2f Compare March 17, 2024 13:13

feat!: remove Transifex calls for OEP-58

6cfe121

OmarIthawi force-pushed the samir/frontend-component-header branch from 4357c2f to 6cfe121 Compare March 17, 2024 13:14

OmarIthawi approved these changes Mar 17, 2024

View reviewed changes

brian-smith-tcril approved these changes Mar 18, 2024

View reviewed changes

brian-smith-tcril merged commit abb08be into openedx:master Mar 22, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: remove Transifex calls for OEP-58 | FC-0012 #416

feat!: remove Transifex calls for OEP-58 | FC-0012 #416

hopewise commented Oct 21, 2023 •

edited

Loading

openedx-webhooks commented Oct 21, 2023 •

edited

Loading

e0d commented Oct 24, 2023

brian-smith-tcril Oct 26, 2023

hopewise Oct 28, 2023

codecov bot commented Oct 28, 2023 •

edited

Loading

OmarIthawi Oct 28, 2023

OmarIthawi Oct 28, 2023

OmarIthawi left a comment

openedx-webhooks commented Mar 22, 2024

feat!: remove Transifex calls for OEP-58 | FC-0012 #416

feat!: remove Transifex calls for OEP-58 | FC-0012 #416

Conversation

hopewise commented Oct 21, 2023 • edited Loading

Breaking change!

Changes

Test results

Merge timeline

Pre-merge checklist

References

openedx-webhooks commented Oct 21, 2023 • edited Loading

e0d commented Oct 24, 2023

brian-smith-tcril Oct 26, 2023

Choose a reason for hiding this comment

hopewise Oct 28, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 28, 2023 • edited Loading

Codecov Report

OmarIthawi Oct 28, 2023

Choose a reason for hiding this comment

OmarIthawi Oct 28, 2023

Choose a reason for hiding this comment

OmarIthawi left a comment

Choose a reason for hiding this comment

openedx-webhooks commented Mar 22, 2024

hopewise commented Oct 21, 2023 •

edited

Loading

openedx-webhooks commented Oct 21, 2023 •

edited

Loading

codecov bot commented Oct 28, 2023 •

edited

Loading