Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #404

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed76e40) 66.86% compared to head (9f55d45) 66.96%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   66.86%   66.96%   +0.09%     
==========================================
  Files          25       25              
  Lines         338      339       +1     
  Branches       78       78              
==========================================
+ Hits          226      227       +1     
  Misses        110      110              
  Partials        2        2              
Files Coverage Δ
src/Menu/Menu.jsx 31.25% <100.00%> (+0.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahwaheed abdullahwaheed merged commit 3c1d215 into master Oct 30, 2023
7 checks passed
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/react-intl-to-formatjs branch October 30, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants